update opentelemetry sdk to 1.58.0 #15817
Conversation
zeitlinger
force-pushed
the
otelbot/update-opentelemetry-sdk-to-1.58.0
branch
from
7e2bdd1 to
4968924
Compare
|
@trask please have a look |
| * This class is internal and is hence not for public use. Its APIs are unstable and can change at | ||
| * any time. | ||
| */ | ||
| public final class ExtendedDeclarativeConfigProperties implements DeclarativeConfigProperties { |
| ExtendedOpenTelemetry otel = mock(ExtendedOpenTelemetry.class); | ||
| ConfigProvider configProvider = mock(ConfigProvider.class); | ||
| ExtendedOpenTelemetry otel = spy(ExtendedOpenTelemetry.class); | ||
| ConfigProvider configProvider = spy(ConfigProvider.class); |
There was a problem hiding this comment.
This enables the default method on both interfaces to be called
| .satisfiesExactlyInAnyOrder( | ||
| metric -> assertThat(metric).hasName("otel.sdk.span.started"), | ||
| metric -> assertThat(metric).hasName("otel.sdk.span.live"), |
There was a problem hiding this comment.
why doesn't this affect other metric tests? do they not use satisfies "exactly"? if not, we could do that here for consistency
There was a problem hiding this comment.
Good point - let me do that in a follow up PR
There was a problem hiding this comment.
just checked: all other metric tests also use satisfiesExactlyInAnyOrder - they just happen to not encounter this metric, because no span is created
There was a problem hiding this comment.
thanks for checking. I think ok for now. if it becomes a problem in the future we can consider loosening the condition or automatically filtering out the sdk metrics
2 participants
No description provided.